Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pull_request_template for release-note 📖 #2882

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

vdemeester
Copy link
Member

Changes

  • The release notes need to use the release-note code block.
  • Do not add any by default to force the block to be added
    accordingly to the PR content.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

- The release notes need to use the `release-note` code block.
- Do not add any by default to *force* the block to be added
  accordingly to the PR content.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@vdemeester
Copy link
Member Author

/cc @jerop
/kind misc

@tekton-robot tekton-robot requested a review from jerop July 1, 2020 10:31
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 1, 2020
@vdemeester
Copy link
Member Author

🤔 why is the check-pr-has-kind-label still red 🤔

@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jul 1, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@piyush-garg
Copy link
Contributor

/test check-pr-has-kind-label

@houshengbo
Copy link

/kind label

@afrittoli afrittoli removed the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 1, 2020
@afrittoli
Copy link
Member

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 1, 2020
@afrittoli
Copy link
Member

Reason for the CI failure: https://dashboard.dogfooding.tekton.dev/#/namespaces/tektonci/taskruns/check-pr-labels-rgx8q

File "/tekton/scripts/script-5-x7m4b", line 6
    prLabels = json.loads('[{"color":"ef8fd9","default":false,"description":"Categorizes issue or PR as a miscellaneuous one.","id":2026949470,"name":"kind/misc","node_id":"MDU6TGFiZWwyMDI2OTQ5NDcw","url":"https://api.github.com/repos/tektoncd/pipeline/labels/kind/misc"},{"color":"6aed75","default":false,"description":"Indicates that a PR is ready to be merged.","id":1053663386,"name":"lgtm","node_id":"MDU6TGFiZWwxMDUzNjYzMzg2","url":"https://api.github.com/repos/tektoncd/pipeline/labels/lgtm"},{"color":"c2e0c6","default":false,"description":"Denotes a PR that doesn't merit a release note.","id":1402691966,"name":"release-note-none","node_id":"MDU6TGFiZWwxNDAyNjkxOTY2","url":"https://api.github.com/repos/tektoncd/pipeline/labels/release-note-none"},{"color":"77bb00","default":false,"description":"Denotes a PR that changes 10-29 lines, ignoring generated files.","id":1060140553,"name":"size/S","node_id":"MDU6TGFiZWwxMDYwMTQwNTUz","url":"https://api.github.com/repos/tektoncd/pipeline/labels/size/S"}]')
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             ^
SyntaxError: invalid syntax

@vdemeester
Copy link
Member Author

/kind misc

@vdemeester
Copy link
Member Author

/kind foo

@vdemeester vdemeester removed the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 1, 2020
@vdemeester
Copy link
Member Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 1, 2020
@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jul 1, 2020
@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jul 1, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@bobcatfish
Copy link
Collaborator

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@tekton-robot tekton-robot merged commit 72e9a19 into tektoncd:master Jul 6, 2020
@vdemeester vdemeester deleted the pr-template-releasenote branch July 6, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants