-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the pull_request_template for release-note 📖 #2882
Update the pull_request_template for release-note 📖 #2882
Conversation
- The release notes need to use the `release-note` code block. - Do not add any by default to *force* the block to be added accordingly to the PR content. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This PR cannot be merged: expecting exactly one kind/ label Available
|
/cc @jerop |
🤔 why is the |
/lgtm |
/test check-pr-has-kind-label |
/kind label |
/kind misc |
Reason for the CI failure: https://dashboard.dogfooding.tekton.dev/#/namespaces/tektonci/taskruns/check-pr-labels-rgx8q
|
/kind misc |
/kind foo |
/kind misc |
This PR cannot be merged: expecting exactly one kind/ label Available
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
release-note
code block.accordingly to the PR content.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes