Remove k8s client validity check from pkg/flags

[zregvart]

Changes

With the addition of cli/pkg/cli/prerun to pkg/cmd/bundle in #1575 the validity of the Kubernetes REST client is checked via invocation of pkg/flags.InitParams where it fails with:

Error: Couldn't get kubeConfiguration namespace: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

A valid Kuberenets configuration should not be supplied for tkn bundle commands, so this removes verifying that the Kuberenets configuration is valid from pkg/flags.InitParams. Seems that the same check for validity is preformed whenever invocation of pkg/cli.Params.Clients is used regardless, so having a check in the InitParams needlessly enforces the requirement of valid Kubernetes configuration.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

tkn bundle commands no longer require valid Kubernetes client parameters

[tekton-robot]

Hi @zregvart. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[piyush-garg]

/ok-to-test

[vinamra28]

/retest

[vinamra28]

/cc @pradeepitm12 @piyush-garg @vdemeester
we might have to cut a patch release for this

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[piyush-garg]

/lgtm