Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tektoncd/plumbing to avoid CI failures #1773

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

vinamra28
Copy link
Member

Changes

E2E tests are failing for the reason

ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400,
  message=Creation of node pools using node images based on Docker
  container runtimes is not supported in GKE v1.23. This is to prepare
  for the removal of Dockershim in Kubernetes v1.24. We recommend that
  you migrate to image types based on Containerd (examples). For more
  information, contact Cloud Support.

The changes have been made in plumbing directory to fix the same, hence bumping.

Signed-off-by: vinamra28 jvinamra776@gmail.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

E2E tests are failing for the reason

```
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400,
  message=Creation of node pools using node images based on Docker
  container runtimes is not supported in GKE v1.23. This is to prepare
  for the removal of Dockershim in Kubernetes v1.24. We recommend that
  you migrate to image types based on Containerd (examples). For more
  information, contact Cloud Support.
```

The changes have been made in plumbing directory to fix the same, hence
bumping.

Signed-off-by: vinamra28 <jvinamra776@gmail.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 3, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2022
@vinamra28
Copy link
Member Author

/retest

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@vdemeester
Copy link
Member

/retest

2 similar comments
@vinamra28
Copy link
Member Author

/retest

@vinamra28
Copy link
Member Author

/retest

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2022
@vinamra28
Copy link
Member Author

/retest

@vinamra28
Copy link
Member Author

/cc @piyush-garg

@piyush-garg
Copy link
Contributor

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@tekton-robot tekton-robot merged commit 20b799f into tektoncd:main Nov 7, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinamra28 vinamra28 deleted the bump-plumbing branch November 7, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants