[cherry-pick] Cp/fix/tr delete with running pr #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ignores all the taskruns attached to pipelinerun which are still running. Behaviour with keep, keep-since, all by default ignores taskruns attached to running pipelinerun. Behaviour if user gives taskrun name to delete will reassure before deleting , if user also specify -f flag then it deletes with a warning msg for each taskrun. this also adds ignore-running-pipelinerun flag. This will help user if they want to delete a taskrun in any case Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
Signed-off-by: vinamra28 <jvinamra776@gmail.com>
vinamra28
force-pushed
the
cp/fix/tr-delete-with-running-pr
branch
from
17f5af4 to
15e8f54
Compare
tekton-robot
added
size/XXL
Since CI is using golang version v1.18.x, using older version of golangci-lint will break the build-tests as it will produce false positives, thus updating to v1.47.2. Also fixing the e2e tests by fixing the version of Pipeline and Triggers to the compatible version.
vinamra28
force-pushed
the
cp/fix/tr-delete-with-running-pr
branch
from
043e41a to
c182a15
Compare
vinamra28
changed the title
|
/kind misc |
tekton-robot
added
the
kind/misc
|
/retest-required |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vinamra28
added a commit
that referenced
this pull request
Oct 31, 2022
null | [vinamra28] New version v0.25.0 | 2022/07/21-22:44 #1759 | [Colin O'Dell] Fix --ignore-running unexpectedly deleting incomplete TaskRuns | 2022/10/26-10:03 #1759 | [Pradeep Kumar] fix taskrun getting deleted of running pipelinerun | 2022/10/26-10:03 #1759 | [vinamra28] [cherry-pick] Fix failing tests | 2022/10/26-10:03 #1759 | [vinamra28] Update golangci-lint to 1.47.2 & update e2e tests | 2022/10/26-10:03 Signed-off-by: vinamra28 <jvinamra776@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this fix tkn ignores to delete all the taskrun(s) attached to pipelinerun which are
still running(without a completion time).
Behaviour with keep, keep-since, all by default ignores taskruns attached to running
pipelinerun.
Behaviour if user gives taskrun name to delete will reassure before deleting, if user
also specify -f flag then it deletes with a warning message for each taskrun.
This also adds ignore-running-pipelinerun flag will helps user to delete a taskrun
attached to a running pipelienrun.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes