Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate v2alpha1 and v2alpha2 #1122

Merged
merged 1 commit into from
May 21, 2024
Merged

Deprecate v2alpha1 and v2alpha2 #1122

merged 1 commit into from
May 21, 2024

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented May 17, 2024 •
edited by chitrangpatel
Loading

Deprecating v2alpha1 and v2alpha2 formatter version.

Related integration tests were removed. Documentation updated.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Deprecation of v2alpha1and v2alpha2 provenance formats. Use v2alpha3, v2alpha4 instead.

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2024
@tekton-robot
Copy link

Hi @renzodavid9. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@renzodavid9 renzodavid9 force-pushed the deprecate-alpha-versions branch from b003122 to d54c819 Compare May 17, 2024 21:15
@renzodavid9 renzodavid9 changed the title Deprecate v2alpha1 and v2alpha3 Deprecate v2alpha1 May 17, 2024
@chitrangpatel
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/format.go 14.5% 20.0% 5.5

@renzodavid9 renzodavid9 force-pushed the deprecate-alpha-versions branch from d54c819 to d42ae95 Compare May 19, 2024 03:15
@renzodavid9
Copy link
Contributor Author

/retest

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/format.go Do not exist 20.0%

@renzodavid9 renzodavid9 marked this pull request as ready for review May 20, 2024 21:53
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
@tekton-robot tekton-robot requested a review from wlynch May 20, 2024 21:53
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/format.go Do not exist 20.0%

@chitrangpatel chitrangpatel changed the title Deprecate v2alpha1 Deprecate v2alpha1 and v2alpha2 May 20, 2024
chitrangpatel
chitrangpatel reviewed May 20, 2024
View reviewed changes
@renzodavid9
Deprecate v2alpha1 and v2alpha2
9f39974 
Deprecating v2alpha1 and v2alpha2 formatter versions
@renzodavid9 renzodavid9 force-pushed the deprecate-alpha-versions branch from d42ae95 to 9f39974 Compare May 21, 2024 00:23
@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/format.go Do not exist 20.0%

lcarva
lcarva approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@tekton-robot tekton-robot merged commit b1773f8 into tektoncd:main May 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitrangpatel chitrangpatel chitrangpatel left review comments

@lcarva lcarva lcarva approved these changes

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@lcarva lcarva

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renzodavid9 @tekton-robot @chitrangpatel @lcarva