Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit parent fields on restriction extensions #908

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jan 2, 2024

📒 Description

When a type has a restriction base, we need to prohibit the use of parent fields that don't appear in the type itself.

Resolves #854

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra mentioned this pull request Jan 2, 2024
4 tasks
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a4883d) 100.00% compared to head (abc523e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #908   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         8728      8749   +21     
  Branches      2067      2075    +8     
=========================================
+ Hits          8728      8749   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit a554aef into main Jan 2, 2024
@tefra tefra deleted the restricted-attrs branch January 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML Schema restrictions are not reflected within __dataclass_fields__ due to inheritance
1 participant