Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always keep forward references for choice types #886

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Dec 16, 2023

📒 Description

Ensures that compound fields in dataclasses maintain forward references, even if postponed annotations are enabled.

Resolves #882

🔗 What I've Done

Add the choice exception to the postpone annotations rule

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6a1c66) 99.89% compared to head (cfd72d3) 99.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         105      105           
  Lines        9311     9311           
  Branches     2080     2080           
=======================================
  Hits         9301     9301           
  Misses          3        3           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward referencing when generating a recursive schema
1 participant