Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PycodeSerializer to escape unicode characters in string values #877

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

SrirachaHorse
Copy link
Contributor

📒 Description

Ensure that unicode characters in PycodeSerializer are correctly escaped and form valid Python code.

Resolves #876

🔗 What I've Done

Escapes any unicode characters in strings while still being represented as ASCII data. Also implements a unit test to exhibit desired behavior.

💬 Comments

None

🛫 Checklist

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (212ca4f) 99.89% compared to head (81b05d3) 99.89%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         105      105           
  Lines        9302     9302           
  Branches     2078     2078           
=======================================
  Hits         9292     9292           
  Misses          3        3           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@tefra tefra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tefra tefra merged commit 0b2fe8b into tefra:main Dec 8, 2023
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PycodeSerializer does not escape strings containing unicode characters
2 participants