Remove dataclasses from xsi_cache with unsupported types #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
xsdata scans all modules for supported models (dataclasses). If the model includes unsupported types these are excluded but it seems now there is trend people are defining dataclasses like these
Which raises a NameError when xsdata tries to analyze the typing annotation, since it's not defined 😮💨
A few versions back, I added a patch for pytest which seems to be doing that a lot, but the patch was a bit flaky because it assumed people would always override a class
__module__
property with something that returns a string, which surprisingly is not always the case 🤦Resolves #795
🔗 What I've Done
💬 Comments
🛫 Checklist