Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min occurs for choice content types #705

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Fix min occurs for choice content types #705

merged 1 commit into from
Sep 5, 2022

Conversation

tefra
Copy link
Owner

@tefra tefra commented Sep 5, 2022

📒 Description

The dtd mapper is not setting the min_occurs restriction correctly for choice elements.

Resolves #703

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

This is still not perfect for cases like this, where elements appear in both choices, the attribute merger will set these fields as list which technically it's not really correct.

<!ELEMENT PaymentRequestDetail (
(PaymentDocumentID , PaymentSequenceNo? , PaymentDates? , 
(
    FinancialInstitutionDetail|
    (OriginatingFinancialInstitution , ReceivingFISpecificID)|
    (OriginatingFISpecificID , (ReceivingFinancialInstitution|ReceivingFISpecificID))|
    CardInfo
) 

🛫 Checklist

@tefra tefra merged commit fb0f3bc into master Sep 5, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tefra tefra deleted the fix-703 branch September 5, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DTD Mapper invalid required restrictions
1 participant