Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute help field is included in equal compariason #209

Closed
tefra opened this issue Jul 11, 2020 · 0 comments
Closed

Attribute help field is included in equal compariason #209

tefra opened this issue Jul 11, 2020 · 0 comments

Comments

@tefra
Copy link
Owner

tefra commented Jul 11, 2020

Two attributes are the same if they have the same name and types all the rest restrictions, default values should be ingnored.

The help field was included by mistake in the comparison fields and in odd schemas this is causing the merge of duplicate attributes handler not to work as expected.
tefra added a commit that referenced this issue Jul 11, 2020
@tefra
Resolve #209 Excldue Attr::help from comparison
032a748 
Notes:
Clean attribute names from prefixes earlier
in the SchemaMapper.

Bonus:
Clean namespaces in wildcard names.
@tefra tefra closed this as completed in 0e5d510 Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tefra