Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 :: (#80) 4096 Bytes Error 해결 #222

Merged
merged 4 commits into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package io.github.v1servicenotification.detail.spi
import java.util.UUID

interface PostDetailUserSpi {
fun getExcludeUserIdList(userIdList: List<UUID>): List<UUID>
fun getExcludeUserIdList(userIdList: List<UUID>?): List<UUID>
fun getDeviceToken(userId: UUID): String
fun getDeviceTokenList(userIdList: List<UUID>): List<String>
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class InMemoryUser: PostDetailUserSpi {
this.userId = userId
}

override fun getExcludeUserIdList(userIdList: List<UUID>): List<UUID> {
override fun getExcludeUserIdList(userIdList: List<UUID>?): List<UUID> {
return listOf(userId)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,24 @@ package io.github.v1servicenotification.domain.user.domain.repository

import io.github.v1servicenotification.detail.spi.PostDetailUserSpi
import io.github.v1servicenotification.infrastructure.feign.client.UserClient
import io.github.v1servicenotification.infrastructure.feign.client.dto.request.ExcludeUserIdsRequest
import io.github.v1servicenotification.infrastructure.feign.error.FeignBadRequestException
import org.springframework.stereotype.Component
import java.util.UUID

@Component
class CustomPostDetailUserImpl(
private val userClient: UserClient
): PostDetailUserSpi {
override fun getExcludeUserIdList(userIdList: List<UUID>): List<UUID> {
return userClient.getExcludeUserIdList(userIdList).userIdList
) : PostDetailUserSpi {
override fun getExcludeUserIdList(userIdList: List<UUID>?): List<UUID> {
val userIdsRequest = ExcludeUserIdsRequest(userIdList)
return userClient.getExcludeUserIdList(userIdsRequest).userIdList
}

override fun getDeviceToken(userId: UUID): String {
val result = userClient.token(listOf(userId)).tokens

if(result.isEmpty()) {
if (result.isEmpty()) {
throw FeignBadRequestException.EXCEPTION
}
return result[0]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package io.github.v1servicenotification.infrastructure.feign.client

import io.github.v1servicenotification.infrastructure.feign.client.dto.request.ExcludeUserIdsRequest
import io.github.v1servicenotification.infrastructure.feign.client.dto.response.TokenResponse
import io.github.v1servicenotification.infrastructure.feign.client.dto.response.UserIdListResponse
import org.springframework.cloud.openfeign.FeignClient
import org.springframework.web.bind.annotation.GetMapping
import org.springframework.web.bind.annotation.RequestBody
import org.springframework.web.bind.annotation.RequestParam
import java.util.UUID

Expand All @@ -14,5 +16,5 @@ interface UserClient {
fun token(@RequestParam("users") userList: List<UUID>): TokenResponse

@GetMapping("/users/exclude")
fun getExcludeUserIdList(@RequestParam("users") userList: List<UUID>): UserIdListResponse
fun getExcludeUserIdList(@RequestBody request: ExcludeUserIdsRequest): UserIdListResponse
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package io.github.v1servicenotification.infrastructure.feign.client.dto.request

import java.util.UUID
import javax.annotation.Nullable

data class ExcludeUserIdsRequest(
@field:Nullable
val userIds: List<UUID>?,
)