🔀 :: (#208) 이미지 추가 전으로 롤백 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyutvs
requested review from
jhhong0509,
jeongjiwoo0522,
eogus2513,
oliver37632,
jaemin05 and
leeseojune53
as code owners
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
============================================
- Coverage 33.79% 33.57% -0.23%
+ Complexity 101 99 -2
============================================
Files 68 68
Lines 719 700 -19
Branches 19 19
============================================
- Hits 243 235 -8
+ Misses 468 457 -11
Partials 8 8
|
|
@lyutvs 왜 롤백하는지 사유는 적어주라 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
디자인 에서 안읽은 알림일 경우 보라색 아이콘을 사용하고 읽은 알림은 회색 을 띄는데 이부분을 바꾸는걸 서버보단 클라이언트에서 처리 하는게 좀더 좋다 생각해서 롤백 시켰습니다 |
leeseojune53
approved these changes
Mar 20, 2023
| @@ -10,7 +10,6 @@ class DetailElement( | |||
| val sentAt: LocalDateTime, | |||
| val isRead: Boolean, | |||
| val userId: UUID, | |||
| val name: String, | |||
| val categoryName: String, | |||
There was a problem hiding this comment.
Q) 요쪽 name -> categoryName은 Client랑 다 이야기된 부분이죠?
eogus2513
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.