Use ConcurrentMap instead of synchronized for class cache #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently developing an application that generates lots of documents in parallel. While profiling I noticed a bottleneck in
OdfXMLFactory#getOdfNodeClass
.Since almost all entries of the Class cache are known after reading some documents, it should be possible to reduce locking and therefore increase parallelism. I firstly tried replacing the
synchronized
-Blocks with a RW-Lock, which resulted in slightly slower execution times. Using a ConcurrentHashMap however almost doubled the document throughput in my application.Therefore I propose the changes in the commit.