Add support for custom headers

[netwolfuk]

eg:
curl -H 'Authorization: Bearer xxxxxxxxxxxxxxxx'

[stinos]

This would be nice indeed; currently looking into using this to get build status into Stride since Hipchat is on it's way out, but that needs the authorization header.

[netwolfuk]

Yeah. That's the exact same reason I was looking into it. :-)

[jacobjohnston]

I was about to make the same request - also for Stride. I've created a new issue to request some Stride templates on top of this. Thanks for the hard work!

[netwolfuk]

Arrg. Atlassian! Why don't you send the WWW-Authenticate header with your 401??!! Many hours wasted.

[netwolfuk]

BTW, I have a first version of "Bearer" running as an WebHookAuthenticator, and have also implemented customised headers.
The former "just works" under the Extra Config tab, so there are no UI changes.

Custom Header support has no UI yet, but hacking the plugin-settings.xml file does work in the following way.

      <headers>
        <header name="Authorization" value="Bearer blahblahblah" />
      </headers>

I'll tidy up the code, and make a test version available over the weekend, and you'll be able to test either method.

The comment above was my frustration at implementing Bearer authentication the correct way with an AuthSchemeProvider for the Apache HttpClient. However, the HttpClient expects a 401 and a WWW-Authenticate header, so that the AuthSchemeProvider code can handle the challenge.

The following from https://tools.ietf.org/html/rfc7235#section-4.1 states:

A server generating a 401 (Unauthorized) response MUST send a WWW-Authenticate header field containing at least one challenge.

However, Atlassian choose not to do that with Stride. I now remember I had a similar problem with Jira a few years ago.

[dgilman]

Thanks for the work netwolf. I am also adding my +1 here as this will allow for Cisco Spark integration.

[netwolfuk]

Hi @dgilman Does Spark use bearer Auth or do you plan to use the headers in another way?

[dgilman]

Yes, it uses bearer auth like you have above, there's a bare bones example at the top of this documentation: https://developer.ciscospark.com/getting-started.html

[netwolfuk]

Ah. Cool. I did a quick Google on my phone and found lots about oauth2, so was just curious. I really should research oauth2 in case that would also be useful.

[netwolfuk]

Here is a build for testing.
https://teamcity.jetbrains.com/viewLog.html?buildId=1388711&tab=artifacts&buildTypeId=WebHooksAndOtherPlugins_TcWebHooks

[netwolfuk]

Clean-up done. Release coming soon.

[netwolfuk]

Docs added

• https://github.com/tcplugins/tcWebHooks/wiki/Enabling-Authentication
• https://github.com/tcplugins/tcWebHooks/wiki/Custom-Headers

[netwolfuk]

New version for testing.
https://teamcity.jetbrains.com/viewLog.html?buildId=1391180&tab=artifacts&buildTypeId=WebHooksAndOtherPlugins_TcWebHooks
I plan to release this version tomorrow, assuming I don't find any issues.

[jacobjohnston]

For what it is worth, I'm now using this version with success! No issues noticed thus far.

[netwolfuk]

Great. Thanks for the feedback. It's now released