Fixed all non-passing tests in call_spec. #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only non-passing tests remaining (though there are admittedly a lot, I think they're all related) are in wrapper_spec.rb.
Partially fixes Issue #36
The tests I fixed were failing because they relied on the exported files from pdftk being exactly identical to a file contained within the gem. This can't ever be guaranteed to be platform/version-independant since even an inconsistency in the order in which the PDFs array of properties enumerates itself (which could be caused by something as simple as a compiler optimization) would cause the test to fail. I parsed the data in these failing tests with a regex and converted them to a hash before comparing and the tests then matched.
Also, @tcocca, I am interested in working more on this project and fixing it up to get it live on RubyGems. I think I can figure out the other testing bugs. I only had a few hours to play with it right now and got pretty far so I thought I'd make this pull request.
Is there any way I could contact you so we can chat briefly at some point if you'd be interested?