Refactor misc. statement tests for parsers #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for the parsing of various statement were expressed using eval. This made the tests more complex than necessary and also prevented the tests from providing value to ECMAScript parsers. Remove the use of eval and instead express the expectations with literal source text. Rename the files to make each test's purpose more clear.
Previously, some tests verified two independent concerns simultaneously: syntactic validity and runtime completion value. The former is relevant for ECMAScript runtimes and parsers alike, but the latter is only observable by runtimes. Express expectations regarding syntactic validity using literal program code so they can be used by parsers. Maintain the original tests which rely on eval in order to preserve coverage for statement completion values.
|
@isiahmeadows I didn't touch a handful of tests from your report in gh-1356:
These tests concern statement completion values, so their use of |
|
Okay. FWIW, I didn't even really create 99% of those tests - I just wrapped
them such that they could be used in other places.
…On Mon, Apr 1, 2019 at 10:30 jugglinmike ***@***.***> wrote:
@isiahmeadows <https://github.com/isiahmeadows> I didn't touch a handful
of tests from your report in gh-1356
<#1356>:
- test/language/statements/do-while/S12.6.1_A5.js
- test/language/statements/do-while/S12.6.1_A8.js
- test/language/statements/for-in/S12.6.4_A3.1.js
- test/language/statements/for-in/S12.6.4_A3.js
- test/language/statements/for-in/S12.6.4_A4.1.js
- test/language/statements/for-in/S12.6.4_A4.js
- test/language/statements/while/S12.6.2_A8.js
These tests concern statement completion values, so their use of eval is
unavoidable. I was tempted to create corresponding syntax tests, but since
they don't describe particularly interesting edge-cases, I decided to skip
that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2117 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AERrBAPKe4-UOQdKi5ItGZSW0Ra_IB33ks5vchfsgaJpZM4cV2x1>
.
|
leobalter
approved these changes
Apr 2, 2019
| break | ||
| FOR1; | ||
| } while(0); | ||
| } |
| description: Using eval | ||
| ---*/ | ||
|
|
||
| var supreme, count; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in service of gh-1356.