-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor directive prologue tests for parsers #1592
Closed
jugglinmike
wants to merge
7
commits into
tc39:master
from
jugglinmike:refactor-for-parsers-directive
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
86a6c08
Rename tests for clarity
jugglinmike 172c494
Normalize coverage
jugglinmike cd2ffd2
Simplify tests for runtime semantics
jugglinmike e95c75b
Add tests for parsing behavior
jugglinmike d8c5d23
Extend metadata with `esid`
jugglinmike c90f799
fixup! Normalize coverage
jugglinmike 90c667a
fixup! Add tests for parsing behavior
jugglinmike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
test/language/directive-prologue/func-decl-inside-func-decl-parse.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Copyright (c) 2018 Mike Pennisi. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: use-strict-directive | ||
es5id: 10.1.1-15-s | ||
description: > | ||
Strict Mode - Function code that is part of a FunctionDeclaration | ||
is strict function code if FunctionDeclaration is contained in use | ||
strict | ||
negative: | ||
phase: early | ||
type: SyntaxError | ||
flags: [noStrict] | ||
---*/ | ||
|
||
function testcase() { | ||
"use strict"; | ||
function fun() { | ||
var static; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
test/language/directive-prologue/func-decl-no-semi-parse.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright (c) 2018 Mike Pennisi. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: use-strict-directive | ||
es5id: 10.1.1-2-s | ||
description: > | ||
Strict Mode - Use Strict Directive Prologue is ''use strict'' | ||
which lost the last character ';' | ||
negative: | ||
phase: early | ||
type: SyntaxError | ||
flags: [noStrict] | ||
---*/ | ||
|
||
function fun() { | ||
"use strict" | ||
var static; | ||
} |
20 changes: 20 additions & 0 deletions
20
test/language/directive-prologue/func-decl-no-semi-runtime.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright (c) 2012 Ecma International. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: use-strict-directive | ||
es5id: 10.1.1-2-s | ||
description: > | ||
Strict Mode - Use Strict Directive Prologue is ''use strict'' | ||
which lost the last character ';' | ||
flags: [noStrict] | ||
---*/ | ||
|
||
function fun() { | ||
"use strict" | ||
test262unresolvable = null; | ||
} | ||
|
||
assert.throws(ReferenceError, function() { | ||
fun(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright (c) 2018 Mike Pennisi. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: use-strict-directive | ||
es5id: 10.1.1-19-s | ||
description: > | ||
Strict Mode - Function code of a FunctionDeclaration contains Use | ||
Strict Directive which appears at the start of the block | ||
negative: | ||
phase: early | ||
type: SyntaxError | ||
flags: [noStrict] | ||
---*/ | ||
|
||
function fun() { | ||
"use strict"; | ||
var static; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
test/language/directive-prologue/func-expr-inside-func-decl-parse.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright (c) 2018 Mike Pennisi. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: use-strict-directive | ||
es5id: 10.1.1-16-s | ||
description: > | ||
Strict Mode - Function code that is part of a FunctionExpression | ||
is strict function code if FunctionExpression is contained in use | ||
strict | ||
negative: | ||
phase: early | ||
type: SyntaxError | ||
flags: [noStrict] | ||
---*/ | ||
|
||
function testcase() { | ||
"use strict"; | ||
var static; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
test/language/directive-prologue/func-expr-no-semi-parse.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright (c) 2018 Mike Pennisi. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: use-strict-directive | ||
es5id: 10.1.1-2-s | ||
description: > | ||
Strict Mode - Use Strict Directive Prologue is ''use strict'' | ||
which lost the last character ';' | ||
negative: | ||
phase: early | ||
type: SyntaxError | ||
flags: [noStrict] | ||
---*/ | ||
|
||
(function() { | ||
"use strict" | ||
|
||
var static; | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright (c) 2018 Mike Pennisi. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: use-strict-directive | ||
es5id: 10.1.1-22-s | ||
description: > | ||
Strict Mode - Function code of a FunctionExpression contains Use | ||
Strict Directive which appears at the start of the block | ||
negative: | ||
phase: early | ||
type: SyntaxError | ||
flags: [noStrict] | ||
---*/ | ||
|
||
(function() { | ||
"use strict"; | ||
|
||
var static; | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we have some coverage for the pragma only preceded by an empty statement. I did not find anything from a quick grep.