-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Add Temporal[@@toStringTag]. #1541
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
- Coverage 95.02% 91.09% -3.93%
==========================================
Files 19 17 -2
Lines 10778 10774 -4
Branches 1725 1608 -117
==========================================
- Hits 10242 9815 -427
- Misses 523 943 +420
- Partials 13 16 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will mark this as "draft" so it's not accidentally merged before being presented to plenary.
If we go with Temporal.now[@@toStringTag] as discussed on #1539 then this PR will need to be updated. |
I believe this is covered by the consensus achieved at the July 2021 TC39 meeting as part of the "Guidance on nested namespaces" item. I will add the updates to |
Fixes #1539. Co-authored-by: Jordan Harband <ljharb@gmail.com>
As per the July 2021 TC39 meeting, this should have the value "Temporal.Now".
Does this change need to be ported to @js-temporal/polyfill? shim.js doesn't exist over there because that polyfill doesn't (yet) put itself in the global namespace, so I wasn't sure how this PR fits in to it, if at all. |
|
Fixes #1539.