clarify equality #43
Merged
clarify equality #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2019 20:58
Clarify that the `Record` and `Tuple` namespaces are not constructors and don't have instances.
mheiber
force-pushed
the
equality-clarification
branch
from
a560de5 to
1cf5965
Compare
ljharb
requested changes
Aug 17, 2019
|
The boxed form, like every object, must only ever be equal to itself. |
|
I'm starting to like |
|
It’d still have to be special, not a normal object - there’d have to be a way to toPrimitive it and extract the underlying Record (another axiom is that all types have at least one unforgeable brand-checking method) |
rickbutton
reviewed
Aug 28, 2019
Don't decide whether there are boxed versions of records and tuples. Put it in the FAQ as an open question for now.
|
Updated the PR to not express an opinion on boxing. Moved the boxing question to FAQ. Thanks @ljharb |
rickbutton
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify what we what we currently know about how the four equality algorithms of JS interact with
RecordandTuple.Note that we have not yet decided on how insertion order interacts with equality.
Update wording to make it clear that there are no boxed Records or Tuples.
close #20