Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: raised minimum/maximum fractional digits from 20 to 100 #786

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Normative: raised minimum/maximum fractional digits from 20 to 100 #786

merged 1 commit into from
Jul 21, 2023

Conversation

ben-allen
Copy link
Contributor

fix #585

Unclear what the consensus was on increasing max fractional digits to match 262, but if we're doing it this PR does it.

ryzokuken
ryzokuken approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec change LGTM, let's check what the consensus is

@ben-allen ben-allen changed the title Normative: raised maximum fractional digits from 20 to 100 Normative: raised minimum/maximum fractional digits from 20 to 100 Jun 1, 2023
@sffc
Copy link
Contributor

sffc commented Jun 2, 2023

TG2 approval: https://github.com/tc39/ecma402/blob/master/meetings/notes-2023-06-01.md#normative-raised-maximum-fractional-digits-from-20-to-100-786

@ryzokuken ryzokuken added the has consensus Has consensus from TC39-TG2 label Jun 22, 2023
@sffc
Copy link
Contributor

sffc commented Jun 30, 2023

TG2 discussion: https://github.com/tc39/ecma402/blob/master/meetings/notes-2023-06-29.md#normative-raised-minimummaximum-fractional-digits-from-20-to-100-786-1

@FrankYFTang
Copy link
Contributor

v8 tracking bug https://bugs.chromium.org/p/v8/issues/detail?id=14170

@FrankYFTang
Copy link
Contributor

v8 change cl https://chromium-review.googlesource.com/c/v8/v8/+/4679294

@FrankYFTang
Copy link
Contributor

The landing of https://chromium-review.googlesource.com/c/v8/v8/+/4679294 is blocked by the merging of this PR.
Also, it seems there are currently no test262 test validate this PR yet.

FrankYFTang added a commit to FrankYFTang/test262 that referenced this pull request Jul 18, 2023
@FrankYFTang
Add tests for ECMA402 PR 786
a922295 
tc39/ecma402#786

This ECMA402 PR 786 reach TC39 consensus in July 2023 meeting
@FrankYFTang FrankYFTang mentioned this pull request Jul 18, 2023
Merged
@FrankYFTang
Copy link
Contributor

test262 tests in tc39/test262#3875

FrankYFTang
FrankYFTang approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@FrankYFTang FrankYFTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is already reach consensus in TC39, it will be nice if you can land this ASAP. Thanks

@eemeli eemeli mentioned this pull request Jul 18, 2023
Merged
@ryzokuken ryzokuken merged commit f6d2945 into tc39:master Jul 21, 2023
Ms2ger pushed a commit to tc39/test262 that referenced this pull request Jul 24, 2023
@FrankYFTang
Add tests for ECMA402 PR 786 (#3875)
92a9eca 
tc39/ecma402#786

This ECMA402 PR 786 reached TC39 consensus in the July 2023 meeting
@FrankYFTang
Copy link
Contributor

thanks for merging this.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 5, 2023
@anba
Bug 1855747: Raise fractional digits limit to 100. r=dminor
c9f06ab 
Implements the changes from <tc39/ecma402#786>.

Drive-by change:
Enable another test which no longer fails.

Differential Revision: https://phabricator.services.mozilla.com/D189541
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 6, 2023
@anba
Bug 1855747: Raise fractional digits limit to 100. r=dminor
833dcc0 
Implements the changes from <tc39/ecma402#786>.

Drive-by change:
Enable another test which no longer fails.

Differential Revision: https://phabricator.services.mozilla.com/D189541
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 8, 2023
@marco-c
Bug 1855747: Raise fractional digits limit to 100. r=dminor
5a5a281 
Implements the changes from <tc39/ecma402#786>.

Drive-by change:
Enable another test which no longer fails.

Differential Revision: https://phabricator.services.mozilla.com/D189541

UltraBlame original commit: 50ef49e1e6cc9c7c73f8aec7ee3375a5b0abf83b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 8, 2023
@marco-c
Bug 1855747: Raise fractional digits limit to 100. r=dminor
1cb8981 
Implements the changes from <tc39/ecma402#786>.

Drive-by change:
Enable another test which no longer fails.

Differential Revision: https://phabricator.services.mozilla.com/D189541

UltraBlame original commit: 50ef49e1e6cc9c7c73f8aec7ee3375a5b0abf83b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 8, 2023
@marco-c
Bug 1855747: Raise fractional digits limit to 100. r=dminor
8967f97 
Implements the changes from <tc39/ecma402#786>.

Drive-by change:
Enable another test which no longer fails.

Differential Revision: https://phabricator.services.mozilla.com/D189541

UltraBlame original commit: 50ef49e1e6cc9c7c73f8aec7ee3375a5b0abf83b
ben-allen added a commit to ben-allen/mdn-content that referenced this pull request May 1, 2024
@ben-allen
Update maximum values of minimumFractionDigits and `maximumFraction…
ed9ff4e 
…Digits` to reflect change made in tc39/ecma402#786
ben-allen added a commit to ben-allen/mdn-content that referenced this pull request May 1, 2024
@ben-allen
Update maximum values of Intl.NumberFormat parameters `minimumFract…
871e593 
…ionDigits` and `maximumFractionDigits` from 20 to 100 to reflect change made in tc39/ecma402#786
@ben-allen ben-allen mentioned this pull request May 1, 2024
Merged
Josh-Cena pushed a commit to mdn/content that referenced this pull request May 1, 2024
@ben-allen
Update maximum values of Intl.NumberFormat parameters `minimumFract…
c0c2485 
…ionDigits` and `maximumFractionDigits` (#33357)

Update maximum values of `Intl.NumberFormat` parameters `minimumFractionDigits` and `maximumFractionDigits` from 20 to 100 to reflect change made in tc39/ecma402#786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@FrankYFTang FrankYFTang FrankYFTang approved these changes

Assignees
No one assigned
Labels
has consensus Has consensus from TC39-TG2 normative
Projects
ECMA-402 Meeting Topics
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit for maximumFractionDigits option for decimal strings formatting
4 participants
@ben-allen @sffc @FrankYFTang @ryzokuken