Fix: make efficient use of available display area

[schlimmchen]

Fixes calculation of the text baselines, using getAscent() in favor of getMaxCharHeight(), which includes ascent and descent. This moves the first text up and allows to insert margin between the lines until the display area is fully utilized.

On large displays, if the small diagram is selected, keep the first line rather low to avoid collision with the diagram y-axis label. in this mode, there is still more space between the text lines as before, allowing for improved readability.

I always thought that the display was quite crammed, especially the last line. While implementing hoylabs#658 I noticed that something was off with the baselines and that we could do better without compromising, since the previous implementation wastes lines mainly on the bottom of the display, also on the top if no diagram is drawn. The y of today nearly touches the l of total.

I found that especially the baseline (_lineOffsets) for the first line was off. The reason is that getMaxCharHeight() returns a value greater than the font's ascent, i.e., it includes the font's descent. The value which should be used is getAscent(). The next line's baseline is then advanced by the previous line's descent, making sure that they will not collide.

The placement is such that even when using the screensaver with the small diagram, the solar power will not collide with the diagram y-axis label.

Using this code

    if (!_isLarge) {
        _display->drawBox(84, 0, 1, 49);
        _display->drawBox(0, 48, 84, 1);
    }
    _isLarge = (_mExtra % 40 < 20);
    calcLineHeights();

I made sure that the change works for small displays as well.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.