move some logic to dedicated method

tbenr · Jan 29, 2024 · 91772e1 · 91772e1
1 parent 75c92d0
commit 91772e1
Showing 1 changed file with 33 additions and 21 deletions.
diff --git a/...layer/src/main/java/tech/pegasys/teku/ethereum/executionlayer/ExecutionBuilderModule.java b/...layer/src/main/java/tech/pegasys/teku/ethereum/executionlayer/ExecutionBuilderModule.java
@@ -212,28 +212,9 @@ public SafeFuture<HeaderWithFallbackData> builderGetHeader(
 
                 logReceivedBuilderBid(signedBuilderBid.getMessage());
 
-                // we give precedence to the requestedBuilderBoostFactor over the BN configured
-                // builderBidCompareFactor
-                final UInt64 actualBuilderBoostFactor;
-                final boolean isRequestedBuilderBoostFactor;
-                if (requestedBuilderBoostFactor.isPresent()) {
-                  actualBuilderBoostFactor = requestedBuilderBoostFactor.get();
-                  isRequestedBuilderBoostFactor = true;
-                } else {
-                  actualBuilderBoostFactor = builderBidCompareFactor;
-                  isRequestedBuilderBoostFactor = false;
-                }
-
                 final boolean localPayloadValueWon =
-                    isLocalPayloadValueWinning(
-                        builderBidValue, localBlockValue, actualBuilderBoostFactor);
-
-                logPayloadValueComparisonDetails(
-                    localPayloadValueWon,
-                    builderBidValue,
-                    localBlockValue,
-                    isRequestedBuilderBoostFactor,
-                    actualBuilderBoostFactor);
+                    calculateIfLocalPayloadWinsAndLog(
+                        requestedBuilderBoostFactor, localBlockValue, builderBidValue);
 
                 if (localPayloadValueWon) {
                   return getResultFromLocalGetPayloadResponse(
@@ -264,6 +245,37 @@ public SafeFuture<HeaderWithFallbackData> builderGetHeader(
             });
   }
 
+  private boolean calculateIfLocalPayloadWinsAndLog(
+      final Optional<UInt64> requestedBuilderBoostFactor,
+      final UInt256 localBlockValue,
+      final UInt256 builderBidValue) {
+    final UInt64 actualBuilderBoostFactor;
+    final boolean isRequestedBuilderBoostFactor;
+
+    // we give precedence to the requestedBuilderBoostFactor over the BN configured
+    // builderBidCompareFactor
+
+    if (requestedBuilderBoostFactor.isPresent()) {
+      actualBuilderBoostFactor = requestedBuilderBoostFactor.get();
+      isRequestedBuilderBoostFactor = true;
+    } else {
+      actualBuilderBoostFactor = builderBidCompareFactor;
+      isRequestedBuilderBoostFactor = false;
+    }
+
+    final boolean localPayloadValueWon =
+        isLocalPayloadValueWinning(builderBidValue, localBlockValue, actualBuilderBoostFactor);
+
+    logPayloadValueComparisonDetails(
+        localPayloadValueWon,
+        builderBidValue,
+        localBlockValue,
+        isRequestedBuilderBoostFactor,
+        actualBuilderBoostFactor);
+
+    return localPayloadValueWon;
+  }
+
   /** 1 ETH is 10^18 wei, Uint256 max is more than 10^77 */
   private boolean isLocalPayloadValueWinning(
       final UInt256 builderBidValue,