Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes are missing quotes around them #126

Closed
cbahiana opened this issue Feb 23, 2021 · 2 comments
Closed

Attributes are missing quotes around them #126

cbahiana opened this issue Feb 23, 2021 · 2 comments
Milestone

Comments

@cbahiana
Copy link
Contributor

Hi tbela99

I decided to give a go with GZIP at https://www.pwabuilder.com/, which I had used before for another project.

Firstly the manifest file was not recognized. As I knew there had been a similar issue before I opened a new issue on this.

There had actually been a problem with manifest parsing, but regardless of that, I also received an informing feed back:

Notice that all the attributes are missing quotes around them. In particular, you have this line:

<link href=/manifest59f9eb28b0efc01bfce6b9b41877cb9d2322f142.json rel=manifest>

It should be changed to:

<link href="/manifest59f9eb28b0efc01bfce6b9b41877cb9d2322f142.json" rel="manifest">

Now the manifest is being recognized, but not in its entirety. Options that were filled in the plugin are still not recognized (attachment).
Screenshot from 2021-02-22 22-53-24

@tbela99
Copy link
Owner

tbela99 commented Feb 23, 2021

unquoted attributes are perfectly valid with HTML5 https://dev.w3.org/html5/spec-LC/syntax.html#unquoted
If you want to check the manifest attributes, you can use your browser console. In this screenshot, I used firefox on github

image

You should note that I may have not implemented support for all attributes because new attributes are added to the specs from time to time. The majority of the attributes listed in your screenshot are supported

@tbela99
Copy link
Owner

tbela99 commented Feb 23, 2021

quotes are removed when you enable HTML minification and the page uses HTML5. Feel free to reopen this issue if you still have questions

@tbela99 tbela99 closed this as completed Feb 23, 2021
@tbela99 tbela99 added this to the V2.9.3 milestone Feb 28, 2021
@tbela99 tbela99 mentioned this issue Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants