-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(features): update store page #1957
docs(features): update store page #1957
Conversation
✅ Deploy Preview for tauri-docs-starlight ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I feel that it could be explicit that |
Actually I do not know the purpose of I was testing the plugin on my Mac and iOS, the behavior seemed different and complicated on mobile. Mac - The backend can interoperate with the frontend without using iOS - The So I'm starting to wonder if the original purpose of the plugin is to let the backend and frontend share the store by default. And the reason we need to use |
It can? How so? Or differently: Do you have a small code example?
Yeah, mobile support is quite fresh and was contributed by a community member. The PR even made with_store private (probably by accident?) so the relation between mobile and with_store is still a bit unknown. I'm also not a fan of with_store in general but back then it looked like it, or something like it would be required (i didn't add it myself). I'd like to rework large parts of the plugin, maybe get it closer to electron-store, maybe we can get rid of with_store then. |
okay, looking at with_store right now it indeed doesn't make that much sense to me anymore to let users use it. The only thing we'd have to think about if we want to remove it is the mobile plugin handle it sets for new stores. I'm not a fan of the explicit api for that, maybe a new storecollection::builder api makes sense idk. That's something to discuss in the plugins repo. If someone agrees with me to remove with_store from the public interface (still makes sense internally ig) then i think we should get rid of it in this PR already. |
I think the name |
completely agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone, LGTM ✅
What kind of changes does this PR include?
features/store
pageDescription
features/store
page