-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to deeplink and file association on macOS #422
Merged
Merged
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
79d8710
feat: add `OpenFile` Event for macOS
meowtec 09588fa
fix: resolve review problems
meowtec 5768f05
feat: use openURLs instead of openFile
meowtec 956e31e
Merge remote-tracking branch 'origin/dev' into feat-open-file
lucasfernog 1bb9da2
Merge branch 'dev' into feat-open-file
lucasfernog 38b4dde
Revert "feat: use openURLs instead of openFile"
meowtec 5e6684b
Event::OpenFile only on macOS
lucasfernog b8f49b8
adjust change file
lucasfernog 1ab70bc
fmt
lucasfernog c708fbe
feat: use openURLs instead of openFile
lucasfernog 4b9dcf4
Merge branch 'dev' into feat-open-file
lucasfernog eaa7f09
use the url crate
lucasfernog 488534a
Merge branch 'dev' into feat-open-file
amrbashir cd999ee
support openFile/Files as well, depending on the feature flag
amrbashir 7bb0e1f
add `macos-open-files` to default features
amrbashir 9f86c01
Merge remote-tracking branch 'origin/dev' into feat-open-file
lucasfernog 5dad1c1
fix build
lucasfernog 041d427
cleanup events
lucasfernog a58525b
determine resourcekind at runtime instead of via feature flags
lucasfernog cfc768f
remove openFile
lucasfernog a4af891
Merge remote-tracking branch 'origin/dev' into feat-open-file
lucasfernog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"tao": minor | ||
--- | ||
|
||
Add `Event::OpenURLs` on macOS. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line throws error since return should be BOOL