Use interpolated values to do formal integral with more shells #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvogl
force-pushed
the
formal-integral-interpolate-sourcefunction
branch
from
b303c67 to
38a30e9
Compare
8 tasks
chvogl
force-pushed
the
formal-integral-interpolate-sourcefunction
branch
2 times, most recently
from
d63b88b to
718f7a4
Compare
|
@chvogl are the refdata still misbehaving ? |
|
@wkerzendorf Yes, the problem still persists. I have run the tests locally with the same cython that is used on Travis and the tests pass. I am currently at a loss to why it does not work on Travis. It must be related to the interpolation in some way. |
chvogl
force-pushed
the
formal-integral-interpolate-sourcefunction
branch
from
718f7a4 to
2929965
Compare
|
@wkerzendorf @unoebauer I have rebased the PR and now all checks pass. |
unoebauer
approved these changes
Oct 31, 2018
|
@chvogl should we just merge this? |
|
@wkerzendorf In principle, I think we can merge this. Do you think we should resolve #878 first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.