[TEP007] Isotope stratified file support #763
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to adding support for reading
stratified abundances with isotopes
. This is rebased over PR #762 (Isotope uniform config)For sample seeing output:
Notebook
abund.dat
Config
Just want to clear 2 things,
I have assumed, only
30 normal elements
(hardcoded in code), and rest isotopes.Currently the header is of following format (for Z=1 to 30 , numbers are used),
1 2 3 4........30 Ni56 Ni58
Do we need the format same as above or format below (represent Z=1 to 30 , as symbols):
H He ......Zn Ni56 Ni58
or you are thinking of some other format.
Will number of
normal elements
bevariable
? . If we want to make normal elements(Z<=30) variable in file, then I can think of this as of now,str
format, because of mixed datatypes (1...30(int
) then isotopes names(str
) ), I could use regex here to find the index at which isotope names(str
) starts,element_symbol2atomic_number
function defined inutil.py
, and at the header index at which it raisesMalformedElementSymbolError
, isotopes will start.