Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hold iterations #638

Closed
wants to merge 6 commits into from
Closed

Conversation

ftsamis
Copy link
Member

@ftsamis ftsamis commented Aug 1, 2016

Fix the following issues:

  • There were cases where the hold_iterations mode was triggered by the convergence_strategy criteria, and the simulation would get in an infinite loop.
  • Improve counting the simulation iterations in the log.
  • Also count the last iteration in the final summary message.

@ftsamis
Copy link
Member Author

ftsamis commented Aug 1, 2016

@wkerzendorf If the hold_iterations in the configuration are set to 0, and an iteration converges, should the simulation be over?

@ftsamis ftsamis force-pushed the fix-hold_iterations branch from 299d67e to 3c21fba Compare August 1, 2016 20:12
@wkerzendorf
Copy link
Member

@ftsamis I would say hold-iterations >=1 as a constraint

@ftsamis
Copy link
Member Author

ftsamis commented Aug 1, 2016

@wkerzendorf Done

@yeganer
Copy link
Contributor

yeganer commented Aug 2, 2016

I don't know if there are plans for further changes to the Simulation logic but while we're at it, I suggest to make all the variables dealing with convergence and iterations local.
Or, if Simulation.iterations_executed are really needed, we should initialize them in init and not there.

@unoebauer
Copy link
Contributor

Should be merged before v2.0

@ftsamis
Copy link
Member Author

ftsamis commented Sep 12, 2016

#652 has a better version of the fix, along with all the other changes I introduced during the summer. Let's close this and focus on #652.

@ftsamis ftsamis closed this Sep 12, 2016
@ftsamis ftsamis deleted the fix-hold_iterations branch December 20, 2016 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants