Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of the config_reader module. #623

Closed
wants to merge 2 commits into from
Closed

Cleanup of the config_reader module. #623

wants to merge 2 commits into from

Conversation

ftsamis
Copy link
Member

@ftsamis ftsamis commented Jul 13, 2016

This PR is to progressively solve issue #579.

  • Remove unnecessary conversions (spectrum_list2dict)
  • Interpret values where they are used (no_of_packes, ...)
  • Clean up Configuration.from_config_dict (move unit conversions to validator maybe?)
  • Remove unused functions(parse_abundance_file_section, parse_supernova_section, parse_density_file_section, parse_model_file_section, etc.)

@ftsamis ftsamis mentioned this pull request Jul 13, 2016
Closed
@ftsamis ftsamis mentioned this pull request Aug 18, 2016
Merged
@ftsamis
Copy link
Member Author

ftsamis commented Nov 19, 2016

This is deprecated by #652.

@ftsamis ftsamis closed this Nov 19, 2016
@ftsamis ftsamis deleted the config_reader-cleanup branch December 20, 2016 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ftsamis @wkerzendorf