Fix convergence handling in run_legacy_simulation - fix issue #593 #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* now all the accessed values exist * not guaranteed that the convergence handling is actually sensible
|
This looks like it'll fix the problem. Do we want to have a test for this problem? |
|
I'm happy to merge this. @yeganer I wouldn't say we need a test now, since we might go down your road and redo the convergence methods. |
|
@wkerzendorf That makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the convergence handling in simulation/base.py, but only in the legacy_simulation function. The changes (should) ensure that all accessed quantities exist. However, this PR does not change anything in the (dubious) convergence handling.