Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Set the exponent property as mandatory when density is exponential #571

Merged
merged 1 commit into from
May 24, 2016

Conversation

ftsamis
Copy link
Member

@ftsamis ftsamis commented May 24, 2016

When model.structure.density is of type exponential, the exponent property was not specified in the config definition neither as required nor as optional, making the validator allowing the following as valid input (note that exponent is missing).

density:
  type : exponential
  time_0: 2. day
  rho_0: 6.e-10 g/cm^3
  v_0: 3000.  km/s

With this PR I'm adding the exponent property as a mandatory one for the exponential density type.

I mainly open a new PR for that because I want to avoid semantic differences between tardis_config_definition.yml and the new json schema at #549

@wkerzendorf wkerzendorf merged commit fa586c0 into tardis-sn:master May 24, 2016
ftsamis added a commit to ftsamis/tardis that referenced this pull request May 24, 2016
ftsamis added a commit to ftsamis/tardis that referenced this pull request May 31, 2016
ftsamis added a commit to ftsamis/tardis that referenced this pull request Jul 19, 2016
ftsamis added a commit to ftsamis/tardis that referenced this pull request Nov 12, 2016
ftsamis added a commit to ftsamis/tardis that referenced this pull request Nov 12, 2016
ftsamis added a commit to ftsamis/tardis that referenced this pull request Nov 12, 2016
@ftsamis ftsamis deleted the fix-density-definition branch December 20, 2016 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants