Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more detailed description of the montecarlo process #310

Merged
merged 3 commits into from
May 27, 2015

Conversation

wkerzendorf
Copy link
Member

After talking to Frederik this morning I whipped this up to give a more detailed description of the montecarlo process to the users. @ssim please confirm that this is correct

@fredRos

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 7136c45 on wkerzendorf:docs/scattering_description into 8ca74ec on tardis-sn:master.

@ssim
Copy link
Contributor

ssim commented May 26, 2015

Hello:

Mostly ok - but we don’t (shouldn’t at least!) assume emission is “isotropic in angle for a half-sphere” - we should be using mu = sqrt(z) [as in Abbott & Lucy 1985], which is not isotropic.

Typically, packets do work on the ejecta and so we expect on average that they lose energy during interactions.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.27% when pulling 7136c45 on wkerzendorf:docs/scattering_description into 8ca74ec on tardis-sn:master.

@wkerzendorf
Copy link
Member Author

@ssim well interestingly enough the escaping packets seem to gain energy.
So I agree that mu=sqrt(z), but presumed that means they are isotropically distributed in theta (mu = cos(theta)) - but maybe that is wrong.

@ssim
Copy link
Contributor

ssim commented May 26, 2015

No - isotropic would not be sqrt! Isotropic would be mu = z (for positive hemisphere).

Overall, work should be done on the ejecta, but it may be that that mainly shows up in the backscattered packets. Also may depend on which frame you calculate the energies in.

@wkerzendorf
Copy link
Member Author

@ssim I just changed the wording. Let me know if we are ready to merge this.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 4cf99ff on wkerzendorf:docs/scattering_description into 8ca74ec on tardis-sn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.27% when pulling 4cf99ff on wkerzendorf:docs/scattering_description into 8ca74ec on tardis-sn:master.

wkerzendorf added a commit that referenced this pull request May 27, 2015
A more detailed description of the montecarlo process
@wkerzendorf wkerzendorf merged commit d5808cd into tardis-sn:master May 27, 2015
@wkerzendorf wkerzendorf deleted the docs/scattering_description branch May 27, 2015 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants