Regression data comparison workflow #2993
Open
+224
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
*beep* *bop* 13 W293 [*] Blank line contains whitespace
1 E999 [ ] SyntaxError: Expected an expression
Complete output(might be large): .github/workflows/compare-regdata.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/compare-regdata.yml:87:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:95:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:100:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:104:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:189:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:191:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:196:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:199:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:204:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:209:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:214:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:219:1: W293 [*] Blank line contains whitespace
.github/workflows/compare-regdata.yml:221:1: W293 [*] Blank line contains whitespace
Found 14 errors.
[*] 13 fixable with the `--fix` option.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2993 +/- ##
==========================================
- Coverage 69.53% 69.17% -0.37%
==========================================
Files 228 228
Lines 16429 16429
==========================================
- Hits 11424 11364 -60
- Misses 5005 5065 +60 ☔ View full report in Codecov by Sentry. |
Regression Data Comparison ResultsThe comparison results have been generated and can be viewed here: 📊 View Comparison PlotsmacOS (not continuum)
macOS (continuum)
Ubuntu (not continuum)
Ubuntu (continuum)
You can also download the artifacts directly from the Actions tab. |
|
*beep* *bop* Significantly changed benchmarks: All benchmarks: Benchmarks that have stayed the same:
| Change | Before [6e790c66] <release-2025.02.23> | After [929f02d6] | Ratio | Benchmark (Parameter) |
|----------|------------------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
| | 7.40±2μs | 9.62±1μs | ~1.30 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley |
| | 3.20±0.4μs | 3.53±0.7μs | ~1.10 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell |
| | 2.28±1μs | 2.04±1μs | ~0.89 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators |
| | 2.93±0.4ms | 2.56±0.4ms | ~0.87 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop |
| | 1.59±0.3μs | 1.33±0.5μs | ~0.84 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line |
| | 46.0±30μs | 49.8±30μs | 1.08 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter |
| | 492±100ns | 521±100ns | 1.06 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation |
| | 1.19±0μs | 1.25±0μs | 1.05 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary |
| | 66.4±0.2ms | 69.7±0.02ms | 1.05 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe |
| | 41.0±20μs | 42.1±20μs | 1.03 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission |
| | 205±0.03ns | 209±0.3ns | 1.02 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body |
| | 1.05±0m | 1.07±0m | 1.01 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking |
| | 6.90±1μs | 6.96±0.8μs | 1.01 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket |
| | 4.15±0.08ms | 4.13±0.1ms | 1.00 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') |
| | 39.2±0s | 39.3±0.2s | 1.00 | run_tardis.BenchmarkRunTardis.time_run_tardis |
| | 2.10±0m | 2.09±0m | 1.00 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions |
| | 38.2±0.02μs | 37.9±0μs | 0.99 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list |
| | 3.18±0.5μs | 3.11±0.1μs | 0.98 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket |
| | 740±1ns | 722±1ns | 0.97 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter |
| | 1.87±0.02ms | 1.77±0ms | 0.95 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop |
| | 611±100ns | 571±100ns | 0.93 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation |
| | 611±100ns | 571±100ns | 0.93 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation |
| | 3.03±0.04ms | 2.79±0.02ms | 0.92 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') |
| | 25.9±8μs | 23.7±6μs | 0.91 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
If you want to see the graph of the results, you can check it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructure📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel