Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pip tests to release workflow #2713

Merged
merged 8 commits into from
Jul 19, 2024

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Jul 17, 2024

📝 Description

Type: 🚦 testing | 🎢 infrastructure

Moves pip tests to release workflow.
Tests will look like
image

Job names will be pip_tests / not continuum rpacket_tracking ubuntu-latest

Made on top of #2699

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 marked this pull request as draft July 17, 2024 05:27
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.47%. Comparing base (c107f27) to head (fb4658c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2713   +/-   ##
=======================================
  Coverage   36.47%   36.47%           
=======================================
  Files         183      183           
  Lines       14664    14664           
=======================================
  Hits         5348     5348           
  Misses       9316     9316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@atharva-2001 atharva-2001 requested a review from jvshields July 18, 2024 07:28
@jvshields jvshields merged commit 8cc2f9f into tardis-sn:master Jul 19, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants