Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent units in packet source #2542

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Mar 11, 2024

📝 Description

Type: 🪲 bugfix

Changes functions in PacketSource to produce quantities, and the packetcollection creator function converts those to raw numpy arrays. Not sure if we want to test the functions explicitly with quantities.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.17%. Comparing base (f515d16) to head (8fa242e).
Report is 10 commits behind head on master.

Files Patch % Lines
tardis/montecarlo/packet_source.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
- Coverage   68.73%   68.17%   -0.56%     
==========================================
  Files         165      168       +3     
  Lines       14001    14217     +216     
==========================================
+ Hits         9624     9693      +69     
- Misses       4377     4524     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@andrewfullard andrewfullard merged commit 7b59fbb into tardis-sn:master Apr 5, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants