-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure/abundance #2445
Restructure/abundance #2445
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2445 +/- ##
==========================================
- Coverage 68.72% 68.36% -0.37%
==========================================
Files 157 158 +1
Lines 13872 13861 -11
==========================================
- Hits 9534 9476 -58
- Misses 4338 4385 +47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the added docstrings. Perhaps push your commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of very minor comments. Otherwise it's better this get merged, assuming the tests (mostly) pass
method names in Composition class
test_gamma_ray_transport.py
update return statement in config_internal.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that the OSX tests are failing.
@andrewfullard on some download thing |
And the next one - useful for @jvshields @Knights-Templars
Still in draft mode but good to look at.