Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure/abundance #2445

Merged
merged 71 commits into from
Dec 4, 2023
Merged

Conversation

wkerzendorf
Copy link
Member

And the next one - useful for @jvshields @Knights-Templars

Still in draft mode but good to look at.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (799e35b) 68.72% compared to head (9706437) 68.36%.
Report is 1 commits behind head on master.

Files Patch % Lines
tardis/io/atom_data/atom_web_download.py 33.33% 6 Missing ⚠️
tardis/simulation/base.py 82.14% 5 Missing ⚠️
tardis/io/configuration/config_internal.py 63.63% 4 Missing ⚠️
tardis/model/parse_input.py 92.15% 4 Missing ⚠️
tardis/io/configuration/config_reader.py 57.14% 3 Missing ⚠️
tardis/model/matter/composition.py 96.15% 3 Missing ⚠️
tardis/model/matter/decay.py 77.77% 2 Missing ⚠️
tardis/visualization/widgets/custom_abundance.py 83.33% 2 Missing ⚠️
tardis/model/tests/test_base.py 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
- Coverage   68.72%   68.36%   -0.37%     
==========================================
  Files         157      158       +1     
  Lines       13872    13861      -11     
==========================================
- Hits         9534     9476      -58     
- Misses       4338     4385      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wkerzendorf wkerzendorf marked this pull request as draft October 18, 2023 19:20
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the added docstrings. Perhaps push your commits?

andrewfullard
andrewfullard previously approved these changes Nov 29, 2023
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of very minor comments. Otherwise it's better this get merged, assuming the tests (mostly) pass

method names in Composition class
andrewfullard
andrewfullard previously approved these changes Nov 29, 2023
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the OSX tests are failing.

@wkerzendorf
Copy link
Member Author

@andrewfullard on some download thing

@jvshields jvshields self-requested a review December 4, 2023 18:17
@wkerzendorf wkerzendorf merged commit caffb25 into tardis-sn:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants