Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Parallelization #2398

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Aug 21, 2023

📝 Description

Type: 🪲 bugfix | ☣️ breaking change

Related to #2021.
Raise error if nthreads!=1, show in the documentation(done in #2399)

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@andrewfullard
Copy link
Contributor

Looks like it defaults to 1 if not defined

@atharva-2001 atharva-2001 marked this pull request as ready for review August 25, 2023 03:33
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2398 (891910e) into master (f80812b) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 50.00%.

❗ Current head 891910e differs from pull request most recent head 2bf7d1f. Consider uploading reports for the commit 2bf7d1f to get more accurate results

@@            Coverage Diff             @@
##           master    #2398      +/-   ##
==========================================
- Coverage   68.49%   68.49%   -0.01%     
==========================================
  Files         145      145              
  Lines       13245    13247       +2     
==========================================
+ Hits         9072     9073       +1     
- Misses       4173     4174       +1     
Files Changed Coverage Δ
tardis/montecarlo/base.py 87.28% <50.00%> (-0.32%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me.

@wkerzendorf wkerzendorf merged commit 0d47bac into tardis-sn:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants