Creating collisional excitation/deexcitation coefficient matrix for NLTE excitation treatment #2385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
==========================================
+ Coverage 68.43% 68.49% +0.05%
==========================================
Files 145 145
Lines 13221 13245 +24
==========================================
+ Hits 9048 9072 +24
Misses 4173 4173
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Christian Vogl <cvogl@mpa-garching.mpg.de>
…an/tardis into create_coll_exc_deexc_matrix
| coll_exc_coefficient.index.get_level_values( | ||
| "level_number_lower" | ||
| ).unique() |
There was a problem hiding this comment.
I would do coll_exc_coefficient.groupby("level_number_lower").sum() before this and assign the result to a variable. You can then use the index of this variable here and the .values of it later.
| -1 | ||
| * coll_exc_coefficient.groupby("level_number_lower") | ||
| .sum() | ||
| .values.flatten() |
There was a problem hiding this comment.
In principle, coll_exc_coefficient should be a Series since it is one column of a DataFrame (corresponding to a specific shell). The .flatten() should then not be necessary.
| coll_exc_coefficient.index.get_level_values( | ||
| "level_number_upper" | ||
| ).unique() |
| -1 | ||
| * coll_deexc_coefficient.groupby("level_number_upper") | ||
| .sum() | ||
| .values.flatten() |
| "level_number_upper" | ||
| ), | ||
| ) | ||
| ] = coll_deexc_coefficient.values.flatten() |
| exc_coeff = pd.DataFrame(coll_exc_coeff_values, index=index) | ||
| deexc_coeff = pd.DataFrame(coll_deexc_coeff_values, index=index) |
There was a problem hiding this comment.
Same as above. These should probably be Series?
|
*beep* *bop* Hi, human. The Click here to see your results. |
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructureThis PR adds a new function which constructs the coefficient matrix portion for NLTE treatment that includes collisional excitation and deexcitation coefficients.
Here is an example of how the matrix should look for 3 levels(0, 1 and 2)
Also, link issues affected by this pull request by using the keywords:
close,closes,closed,fix,fixes,fixed,resolve,resolvesorresolved.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel