Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks Push To Repo Bug Fix #2330

Merged

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix 🎢 infrastructure
The benchmarks workflow fails to send files to the remote repo because the env files contain .git folders. This PR fixes that.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

andrewfullard
andrewfullard previously approved these changes Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #2330 (86d1910) into master (b79a6f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 86d1910 differs from pull request most recent head b417798. Consider uploading reports for the commit b417798 to get more accurate results

@@           Coverage Diff           @@
##           master    #2330   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files         137      137           
  Lines       12516    12516           
=======================================
  Hits         9008     9008           
  Misses       3508     3508           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atharva-2001 atharva-2001 requested a review from chvogl June 21, 2023 13:18
@andrewfullard andrewfullard disabled auto-merge June 29, 2023 20:05
@andrewfullard andrewfullard merged commit ad9c67b into tardis-sn:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants