Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resturcture ABCs import from collections module #2106

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

blackbird7112
Copy link
Contributor

📝 Description

Type: 🪲 bugfix

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Change import of ABCs from 'collections' to 'collections.abc' because the old import will fail in future versions of python.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

Resolves #1903

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2106 (35aea57) into master (6269996) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 35aea57 differs from pull request most recent head 667dc6e. Consider uploading reports for the commit 667dc6e to get more accurate results

@@           Coverage Diff           @@
##           master    #2106   +/-   ##
=======================================
  Coverage   58.13%   58.13%           
=======================================
  Files          75       75           
  Lines        8602     8602           
=======================================
  Hits         5001     5001           
  Misses       3601     3601           
Impacted Files Coverage Δ
tardis/io/util.py 77.98% <50.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andrewfullard andrewfullard merged commit 406fdbc into tardis-sn:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change import of ABCs from 'collections' to 'collections.abc'
2 participants