Added v_inner and v_outer, enable_nonhomologous_expansion for future use in nonhomologous expansion #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure your changes are PEP 8 compliant, you can just run |
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
==========================================
- Coverage 60.01% 59.87% -0.14%
==========================================
Files 70 70
Lines 8115 8157 +42
==========================================
+ Hits 4870 4884 +14
- Misses 3245 3273 +28
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Rodot-
approved these changes
May 16, 2022
|
@wkerzendorf when you have a chance, can you look through this? I think it's ready to be merged. |
andrewfullard
requested changes
May 20, 2022
wkerzendorf
reviewed
May 23, 2022
| @@ -117,7 +117,7 @@ def formal_integral_model(request): | |||
| This gets the Numba model to be used in later tests | |||
| """ | |||
| r = request.param["r"] | |||
| model = NumbaModel(r[:-1], r[1:], 1 / c.c.cgs.value) | |||
| model = NumbaModel(r[:-1], r[1:], r[:-1], r[1:], 1 / c.c.cgs.value) | |||
There was a problem hiding this comment.
please change to velocities
andrewfullard
approved these changes
May 26, 2022
6 tasks
epassaro
pushed a commit
to epassaro/tardis
that referenced
this pull request
Jun 2, 2022
…use in nonhomologous expansion (tardis-sn#2024) * added v_outer and v_inner to NumbaModel * defined default value for v_inner and v_outer in NumbaModel * added enable_nonhomologous_expansion to io/schemas/montecarlo.yml * added v_inner and v_outer to NumbaPlasma * added v_inner and v_outer as arguments for NumbaModel in run() in montecarlo_numba * added v_outer_cgs to MonteCarloRunner * removed a comment * ran black on the changed files * added right arguments in test * added v_inner, v_outer to tests * added temporary fix to formal_integral.py * ran black on modified files * changed dummy values in the test * Reverted content of file. * made needed change in test_cuda_formal_integral.py * made needed change in test_numba_formal_integral.py
epassaro
added a commit
to epassaro/tardis
that referenced
this pull request
Jun 2, 2022
* Fix bot aliases in .mailmap (tardis-sn#2038) * Added v_inner and v_outer, enable_nonhomologous_expansion for future use in nonhomologous expansion (tardis-sn#2024) * added v_outer and v_inner to NumbaModel * defined default value for v_inner and v_outer in NumbaModel * added enable_nonhomologous_expansion to io/schemas/montecarlo.yml * added v_inner and v_outer to NumbaPlasma * added v_inner and v_outer as arguments for NumbaModel in run() in montecarlo_numba * added v_outer_cgs to MonteCarloRunner * removed a comment * ran black on the changed files * added right arguments in test * added v_inner, v_outer to tests * added temporary fix to formal_integral.py * ran black on modified files * changed dummy values in the test * Reverted content of file. * made needed change in test_cuda_formal_integral.py * made needed change in test_numba_formal_integral.py * Update README.rst in post-release (tardis-sn#2037) * Fix docs badge * Add license badge * First attempt of creating credits.rst and README.rst via templates * Working version * Restore old README.rst * Update post-release workflow * Change .gitignore * Various fixes * Check PEP8 on CI (tardis-sn#2039) * Add Flake8 job * Change to file description * Test payload Co-authored-by: Sona Chitchyan <chitchyan.sona@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds v_inner and v_outer to NumbaModel as arguments, taking them from MonteCarloRunner. This will be used in the future for the implementation of the nonhomologous expansion.
Motivation and context
How has this been tested?
Examples
Type of change
Checklist
build_docslabel to this pull request (if you don't have enough privileges a reviewer will do it for you)