Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering Levels Parameter within Plasma Calculations #1899

Merged
merged 6 commits into from
Mar 28, 2022

Conversation

bartnikm
Copy link
Contributor

Description

This aims to move the filtering of atomic properties within the levels parameter from the atom data module to the plasma module

Motivation and context

Its current location within the atom data module is underneath the prepare_atom_data function, while placing it within the plasma module within the atomic.py module will allow TARDIS to filter the levels data after preparing the atomic data and not during.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1899 (54c15fb) into master (e7c2ec3) will not change coverage.
The diff coverage is n/a.

❗ Current head 54c15fb differs from pull request most recent head 2a82dc1. Consider uploading reports for the commit 2a82dc1 to get more accurate results

@@           Coverage Diff           @@
##           master    #1899   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files          70       70           
  Lines        7843     7843           
=======================================
  Hits         4609     4609           
  Misses       3234     3234           
Impacted Files Coverage Δ
tardis/tardis/io/atom_data/base.py 89.71% <0.00%> (-0.06%) ⬇️
tardis/tardis/plasma/properties/atomic.py 53.12% <0.00%> (ø)
...dis/montecarlo/montecarlo_numba/formal_integral.py 51.36% <0.00%> (+0.16%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bartnikm bartnikm marked this pull request as ready for review March 13, 2022 19:19
@Rodot- Rodot- self-requested a review March 28, 2022 14:30
@andrewfullard andrewfullard merged commit 5d6e229 into tardis-sn:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants