move transport related parts to r_packet_transport #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from r_packet.py (which is only for definitions)
|
Before a pull request is accepted, it must meet the following criteria:
|
| @@ -6,6 +6,7 @@ | |||
| import tardis.montecarlo.montecarlo_numba.calculate_distances as calculate_distances | |||
| import tardis.montecarlo.montecarlo_numba.frame_transformations as frame_transformations | |||
| import tardis.montecarlo.montecarlo_numba.opacities as opacities | |||
| import tardis.montecarlo.montecarlo_numba.r_packet_transport | |||
There was a problem hiding this comment.
I would change this to add as r_packet_transport
| @@ -50,6 +50,7 @@ | |||
| import pandas as pd | |||
| import tardis.montecarlo.montecarlo_numba.formal_integral as formal_integral | |||
| import tardis.montecarlo.montecarlo_numba.r_packet as r_packet | |||
| import tardis.montecarlo.montecarlo_numba.r_packet_transport | |||
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
+ Coverage 62.21% 62.24% +0.02%
==========================================
Files 66 67 +1
Lines 6826 6830 +4
==========================================
+ Hits 4247 4251 +4
Misses 2579 2579
Continue to review full report at Codecov.
|
wkerzendorf
force-pushed
the
montecarlo/refactor_r_packet
branch
from
d561eeb to
7850bf8
Compare
Rodot-
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from r_packet.py (which is only for definitions)