-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin jsonschema
to v3
#1806
Pin jsonschema
to v3
#1806
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1806 +/- ##
=======================================
Coverage 58.38% 58.38%
=======================================
Files 66 66
Lines 6705 6705
=======================================
Hits 3915 3915
Misses 2790 2790 Continue to review full report at Codecov.
|
Before a pull request is accepted, it must meet the following criteria:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for discovering the fix
If this solves the problem, do not pin EDIT: also remember the |
TARDIS tests were failing because a few methods in
jsonschema
have been removed as per their deprecation policy.This PR pins
jsonschema
to a previous version so that tests can run.Description
The test with
jsonschema
v4.0.1 failed and the one with v3.2.0 passed. This PR pinsjsonschema
to v3, which should allow tests to pass. For reference, please compare recentjsonschema
releases here: https://github.com/Julian/jsonschema/releasesMotivation and context
Also fixes #1807
How has this been tested?
Examples
Type of change
Checklist