Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jsonschema to v3 #1806

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Oct 4, 2021

TARDIS tests were failing because a few methods in jsonschema have been removed as per their deprecation policy.
This PR pins jsonschema to a previous version so that tests can run.

Description

The test with jsonschema v4.0.1 failed and the one with v3.2.0 passed. This PR pins jsonschema to v3, which should allow tests to pass. For reference, please compare recent jsonschema releases here: https://github.com/Julian/jsonschema/releases

Motivation and context

Also fixes #1807

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #1806 (d4fbe0c) into master (e6a8af2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1806   +/-   ##
=======================================
  Coverage   58.38%   58.38%           
=======================================
  Files          66       66           
  Lines        6705     6705           
=======================================
  Hits         3915     3915           
  Misses       2790     2790           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a8af2...d4fbe0c. Read the comment docs.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@atharva-2001 atharva-2001 marked this pull request as ready for review October 4, 2021 14:50
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for discovering the fix

@epassaro
Copy link
Member

epassaro commented Oct 5, 2021

If this solves the problem, do not pin jsonschema so hard. It's enough to do jsonschema=3. And point out the issue in a comment, otherwise we don't know why some dependencies are pinned.

EDIT: also remember the conda-forge recipe is independent from the environment file located in the tardis repo, so this must be changed there too.

@atharva-2001 atharva-2001 changed the title Pin jsonschema to v3.2.0 Pin jsonschema to v3 Oct 5, 2021
@andrewfullard andrewfullard merged commit c1b5077 into tardis-sn:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run Tardis Example after re-installation
4 participants