Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileExistsError in to_hdf() #1630

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

yuyizheng1112
Copy link
Contributor

Fix #1624.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples
Before the change:
image

After the change:
image

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1630 (012af2a) into master (e062c69) will decrease coverage by 5.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
- Coverage   67.20%   61.94%   -5.27%     
==========================================
  Files          73       62      -11     
  Lines        6150     5728     -422     
==========================================
- Hits         4133     3548     -585     
- Misses       2017     2180     +163     
Impacted Files Coverage Δ
tardis/tardis/util/base.py 75.78% <0.00%> (-1.99%) ⬇️
tardis/tardis/montecarlo/montecarlo_numba/base.py 28.73% <0.00%> (-0.90%) ⬇️
tardis/tardis/simulation/base.py 85.16% <0.00%> (-0.47%) ⬇️
tardis/tardis/scripts/cmfgen2tardis.py 0.00% <0.00%> (ø)
tardis/tardis/montecarlo/packet_source.py 97.29% <0.00%> (ø)
tardis/tardis/plasma/properties/atomic.py 61.76% <0.00%> (ø)
...dis/montecarlo/montecarlo_numba/tests/test_base.py
...s/montecarlo/montecarlo_numba/tests/test_packet.py
...tecarlo/montecarlo_numba/tests/test_interaction.py
...rdis/montecarlo/montecarlo_numba/tests/conftest.py
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e062c69...012af2a. Read the comment docs.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@yuyizheng1112 yuyizheng1112 requested a review from wkerzendorf June 7, 2021 17:08
Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch @yuyizheng1112 - thanks for fixing it!

@jaladh-singhal jaladh-singhal requested a review from Rodot- June 17, 2021 19:49
@andrewfullard andrewfullard merged commit cb13a63 into tardis-sn:master Jun 22, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Fix FileExistsError in to_hdf()

* Apply black formatter

* Changed option to function parameter since it's more clear

Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_hdf() failed for Simulation object
5 participants