-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FileExistsError in to_hdf() #1630
Fix FileExistsError in to_hdf() #1630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
==========================================
- Coverage 67.20% 61.94% -5.27%
==========================================
Files 73 62 -11
Lines 6150 5728 -422
==========================================
- Hits 4133 3548 -585
- Misses 2017 2180 +163
Continue to review full report at Codecov.
|
Before a pull request is accepted, it must meet the following criteria:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch @yuyizheng1112 - thanks for fixing it!
* Fix FileExistsError in to_hdf() * Apply black formatter * Changed option to function parameter since it's more clear Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>
Fix #1624.
How has this been tested?
Examples

Before the change:
After the change:

Type of change
Checklist