-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporating old physics section of the documentation #1470
Incorporating old physics section of the documentation #1470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1470 +/- ##
=======================================
Coverage 71.13% 71.13%
=======================================
Files 67 67
Lines 5523 5523
=======================================
Hits 3929 3929
Misses 1594 1594 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this very essential PR - docs are neater now. Plasma section looks great.
And for montecarlo section, @smithis7 I'm assuming that you have confirmed with @wkerzendorf and/or @andrewfullard that we don't need anything except doppler shift graph from old documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once the tests pass
Apparently the tests did not pass. I'm not entirely sure why. |
* incorporating old_physics * adding distance calculation images
This pull request incorporates the "old physics" section of the documentation into the updated physics section.
Description
Changes include:
docs/physics/montecarlo/propogation.rst
.docs/physics/plasma/index.rst
.docs/physics/plasma/index.rst
to give more context to the pages linked in toctrees.docs/physics/old_physics/
and removed it from the toctree in ``docs/index.rst```.Motivation and Context
This pull request addresses issue #1422.
How Has This Been Tested?
I built the docs locally and made sure that no new warnings occurred.
Screenshots (if appropriate):
Types of changes
Checklist: