Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Kromer Plot to Spectral Element Decomposition (SEDec) Plot #1424

Merged
merged 4 commits into from
Jan 28, 2021

Conversation

jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Jan 26, 2021

Renamed Kromer by Spectral Element Decomposition (SEDec) throughout the module and also renamed the module.

Motivation and Context

Kromer Plot name is very uninformative to the broader community. Also as @wkerzendorf pointed out:

There has been a push in general in astronomy to separate ideas from names for several reasons (e.g. renaming maxwell equations).

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

I've ran the Kromer Plot demo notebook after these changes, everything works as expected.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #1424 (5864c3f) into master (a6d190c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1424   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files          67       67           
  Lines        5521     5521           
=======================================
  Hits         3929     3929           
  Misses       1592     1592           
Impacted Files Coverage Δ
tardis/tardis/widgets/kromer_plot.py
tardis/tardis/widgets/sedec_plot.py 16.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fd51c...5864c3f. Read the comment docs.

@jamesgillanders
Copy link
Member

So this all looks good, but are we definitely going with SED or is this needing to be updated/changed?

@jaladh-singhal
Copy link
Member Author

Since SED already stands for Spectral Energy Distribution, changed it to SEDec

@jaladh-singhal jaladh-singhal changed the title Rename Kromer Plot to Spectral Element Decomposition (SED) Plot Rename Kromer Plot to Spectral Element Decomposition (SEDec) Plot Jan 27, 2021
@andrewfullard andrewfullard merged commit 68bc12a into tardis-sn:master Jan 28, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
…rdis-sn#1424)

* Renamed Kromer Plot to SED Plot throughout the module

* Rename kromer_plot file name to sed_plot

* Changed SED to SEDec

* Added subpackage docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants