Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment file #1393

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Dec 16, 2020

Description

  • Removed useless numpy fix
  • Pin pyne to less restrictive 0.7 (previously 0.7.0)
  • Move pyside to Widgets section

Motivation and Context

Just a regular update of TARDIS env. Mainly motivated by the restrictive pin to pyne version.

How Has This Been Tested?

Azure tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft December 16, 2020 14:59
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #1393 (4f93aa5) into master (23ac153) will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   72.38%   73.44%   +1.06%     
==========================================
  Files          66       66              
  Lines        5098     5302     +204     
==========================================
+ Hits         3690     3894     +204     
  Misses       1408     1408              
Impacted Files Coverage Δ
tardis/tardis/widgets/tests/test_line_info.py 100.00% <0.00%> (ø)
tardis/tardis/widgets/tests/test_shell_info.py 100.00% <0.00%> (ø)
...dis/montecarlo/montecarlo_numba/tests/test_base.py 100.00% <0.00%> (ø)
...s/montecarlo/montecarlo_numba/tests/test_packet.py 100.00% <0.00%> (ø)
.../montecarlo/montecarlo_numba/tests/test_vpacket.py 100.00% <0.00%> (ø)
...ntecarlo/montecarlo_numba/tests/test_macro_atom.py 100.00% <0.00%> (ø)
...tecarlo/montecarlo_numba/tests/test_interaction.py 100.00% <0.00%> (ø)
...rlo/montecarlo_numba/tests/test_numba_interface.py 100.00% <0.00%> (ø)
tardis/tardis/plasma/properties/general.py 98.46% <0.00%> (+0.07%) ⬆️
tardis/tardis/simulation/base.py 85.71% <0.00%> (+0.08%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ac153...4f93aa5. Read the comment docs.

@epassaro epassaro added the conda label Dec 16, 2020
@epassaro epassaro requested a review from wkerzendorf December 16, 2020 15:51
@epassaro epassaro marked this pull request as ready for review December 16, 2020 15:54
@epassaro epassaro requested a review from arjunsavel December 17, 2020 12:31
@wkerzendorf wkerzendorf merged commit e2243ce into tardis-sn:master Jan 8, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants