Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon of result items to real program icon #23

Closed
wants to merge 1 commit into from

Conversation

pc223
Copy link

@pc223 pc223 commented Aug 9, 2021

I'm trying to get the real program icon for the results, seems work only the first query, after that fails, not sure why yet 👀

@jjw24
Copy link
Collaborator

jjw24 commented Aug 9, 2021

i was going to suggest this but forgot. I think the default kill process plugin does this, so can have a look at that plugin to see how it's done (although the kill process plugin has a lot of icons not loaded).

@taooceros
Copy link
Owner

A question for this is it will make windowswalker harder to be distinguished with program plugin.

@jjw24
Copy link
Collaborator

jjw24 commented Dec 31, 2021

that's true actually, i never thought of it that way because i use it with a shortcut. What does PowerToys do with their icons for WindowWalker?

@taooceros
Copy link
Owner

that's true actually, i never thought of it that way because i use it with a shortcut. What does PowerToys do with their icons for WindowWalker?

they leave it like this.

@jjw24
Copy link
Collaborator

jjw24 commented Jan 6, 2022

Should we maybe leave it how it is currently as well? Or make it distinguishable via subtitle e.g. 'From Window Walker- processname.exe'

@taooceros
Copy link
Owner

Should we maybe leave it how it is currently as well? Or make it distinguishable via subtitle e.g. 'From Window Walker- processname.exe'

Maybe let's try implementing a small image indicating which plugin is responsible for the results? @onesounds what do you think?

@onesounds
Copy link

Should we maybe leave it how it is currently as well? Or make it distinguishable via subtitle e.g. 'From Window Walker- processname.exe'

Maybe let's try implementing a small image indicating which plugin is responsible for the results? @onesounds what do you think?

  • It seems good that the icon of the program is displayed.
  • Isn't it already coming out of the subtitle as to what plug-in it is working with? In the form of "Running: Something" If you feel that this is not enough, the syntax proposed by JJw also looks good.
  • Additional image display is unnecessary and I think the current subtitle is sufficient.

@jjw24
Copy link
Collaborator

jjw24 commented Jan 7, 2022

I am ok with current subtitle as well or my proposed one, up to @taooceros if you want change or keep it how it is now.

Have this been tested and ready to go?

@taooceros
Copy link
Owner

close in favor of #38

@taooceros taooceros closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants